[PATCH] D92363: [HIP] Warn no --offload-arch option

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 1 12:23:17 PST 2020


tra added a comment.

While I agree that the default GPU choice is not likely to be correct, or usable, for everyone, but the warning seems to be a half-measure.
If the default is not usable, then it should not be the default. If it's usable, then we don't need a warning.

Having a warning would make sense if it were a part of the plan to transition towards making GPU arch a mandatory option. Is that the case here?
Just a warning is not very useful, IMO. The users would need to specify the GPU in order to silence it, so why not just require it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92363/new/

https://reviews.llvm.org/D92363



More information about the cfe-commits mailing list