[PATCH] D92418: [hip] Fix host object creation from fatbin

Michael Liao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 1 12:05:46 PST 2020


hliao created this revision.
hliao added reviewers: yaxunl, ashi1.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
hliao requested review of this revision.

- `__hip_fatbin` should a symbol in `.hip_fatbin` section.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92418

Files:
  clang/lib/Driver/ToolChains/HIP.cpp


Index: clang/lib/Driver/ToolChains/HIP.cpp
===================================================================
--- clang/lib/Driver/ToolChains/HIP.cpp
+++ clang/lib/Driver/ToolChains/HIP.cpp
@@ -178,8 +178,7 @@
   ObjStream << "#       HIP Object Generator\n";
   ObjStream << "# *** Automatically generated by Clang ***\n";
   ObjStream << "  .type __hip_fatbin, at object\n";
-  ObjStream << "  .section .hip_fatbin,\"aMS\", at progbits,1\n";
-  ObjStream << "  .data\n";
+  ObjStream << "  .section .hip_fatbin,\"a\", at progbits\n";
   ObjStream << "  .globl __hip_fatbin\n";
   ObjStream << "  .p2align " << llvm::Log2(llvm::Align(HIPCodeObjectAlign))
             << "\n";


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92418.308732.patch
Type: text/x-patch
Size: 670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201201/77e511e4/attachment-0001.bin>


More information about the cfe-commits mailing list