[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

Tue Dec 1 10:14:09 PST 2020

aeubanks added a comment.

In D92072#2425025 <https://reviews.llvm.org/D92072#2425025>, @hans wrote:

> Seems like a good idea to me.
>
> From the change description:
>
>> This allows us to use its value everywhere, rather than just llvm.
>
> Do you mean rather than just clang?

Whoops, yup.

================
Comment at: llvm/include/llvm/Config/llvm-config.h.cmake:95
+/* Define to 1 to enable the experimental new pass manager by default */
+#cmakedefine01 ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER
+
----------------
rnk wrote:
> This should be namespaced in LLVM_*.
> 
> Can we drop "experimental" now to shorten it? LLVM_ENABLE_NEW_PASS_MANAGER?
That would mean changing the CMake variable name which would break everybody using the flag. I can add a #define alias if you want.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92072/new/

https://reviews.llvm.org/D92072