[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew
Nico Weber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 1 09:10:24 PST 2020
thakis updated this revision to Diff 308684.
thakis edited the summary of this revision.
thakis added a comment.
rebase
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92357/new/
https://reviews.llvm.org/D92357
Files:
clang/lib/Driver/ToolChains/Darwin.cpp
Index: clang/lib/Driver/ToolChains/Darwin.cpp
===================================================================
--- clang/lib/Driver/ToolChains/Darwin.cpp
+++ clang/lib/Driver/ToolChains/Darwin.cpp
@@ -698,7 +698,10 @@
}
ResponseFileSupport ResponseSupport;
- if (Version[0] >= 607 || LinkerIsLLDDarwinNew) {
+ if (LinkerIsLLDDarwinNew) {
+ // Xcode12's ld64 added support for @response files, but it's crashy:
+ // https://openradar.appspot.com/radar?id=4933317065441280
+ // FIXME: Pass this for ld64 once it no longer crashes.
ResponseSupport = ResponseFileSupport::AtFileUTF8();
} else {
// For older versions of the linker, use the legacy filelist method instead.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92357.308684.patch
Type: text/x-patch
Size: 703 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201201/22b1680f/attachment.bin>
More information about the cfe-commits
mailing list