[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

Thanks again for the review, landed in 1b042de5b29af4869a77ecbc632029fba0313dec <https://reviews.llvm.org/rG1b042de5b29af4869a77ecbc632029fba0313dec>.



================
Comment at: clang/unittests/Basic/FileEntryTest.cpp:95
 
   OptionalFileEntryRefDegradesToFileEntryPtr M0;
   OptionalFileEntryRefDegradesToFileEntryPtr M1 = R1;
----------------
dexonsmith wrote:
> jansvoboda11 wrote:
> > Dead variable, do we need it?
> Thanks, nice catch, that looks vestigial. I'll delete that line in a follow-up.
Deleted this stray line in 94f537c6b2bb55c8e058a9989d02ab0d68a0c61a; turns out it was originally a copy/paste bug from ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90484/new/

https://reviews.llvm.org/D90484