[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex
Sam Elliott via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 30 14:34:40 PST 2020
lenary added a comment.
LGTM - the big hint is that the new test is handled the same as `f_empty_double2` as required by the ABI.
================
Comment at: clang/test/CodeGen/riscv32-ilp32d-abi.cpp:36
+
+struct empty_complex { struct {}; double _Complex fc; };
+
----------------
Please can you add a test of `{ struct {}; float _Complex fc;}` too, just for regression purposes?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91278/new/
https://reviews.llvm.org/D91278
More information about the cfe-commits
mailing list