[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 30 10:28:17 PST 2020


MaskRay added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:2176
+    } else {
+      // FIXME dereferenceable should be correct here, regardless of
+      // NullPointerIsValid.  However, dereferenceable currently does not always
----------------
@rsmith @jdoerfert Am I right about the FIXME issue here?

Should I link to D66618 instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92297/new/

https://reviews.llvm.org/D92297



More information about the cfe-commits mailing list