[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

dmajor via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 30 09:06:01 PST 2020


dmajor added a comment.

In D91747#2412346 <https://reviews.llvm.org/D91747#2412346>, @alanphipps wrote:

> Looks like _LIBCPP_HAS_NO_THREADS is being set for libcxxabi, and the build now fails with this change:
>
> llvm-project/libcxxabi/../libcxx/include/__config:1172:2: error: _LIBCPP_HAS_NO_THREADS cannot be set when __STDCPP_THREADS__ is set

Indeed: LIBCXX_ENABLE_THREADS is off by default.

@zequanwu, what's your take on this... which part of the system needs to adapt?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91747/new/

https://reviews.llvm.org/D91747



More information about the cfe-commits mailing list