[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anton Zabaznov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 29 08:57:13 PST 2020


azabaznov added a comment.

> I didn't want to end up with a big refactoring from this patch but now I start to think that considering the situation it might be unavoidable. :(

Well, it was expected. However, I didn't want to mess this refactoring with OpenCL C 3.0 support at first.

I already do have some progress in this direction: https://reviews.llvm.org/D92277. We can differentiate between core and optional features by the defining them appropriately in `OpenCLExtensions.def`. Note that this also removes duplication of `OpenCLOptions` so we can query all features/extensions from `TargetInfo` directly. This will also allow simplifying `OpenCLOptions` in future


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89869/new/

https://reviews.llvm.org/D89869



More information about the cfe-commits mailing list