[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

[John Paul Adrian Glaubitz via Phabricator via cfe-commits]

glaubitz added a comment.

Not sure if this is related, but on SPARC, stage2 builds recently started to fail with:

  [379/5552] Building CXX object projects/compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.sparc.dir/ubsan_diag.cpp.o
  FAILED: projects/compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.sparc.dir/ubsan_diag.cpp.o
  /home/glaubitz/llvm-project/build/./bin/clang++ -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iprojects/compiler-rt/lib/ubsan -I/home/glaubitz/llvm-project/compiler-rt/lib/ubsan -Iinclude -I/home/glaubitz/llvm-project/llvm/include -I/home/glaubitz/llvm-project/compiler-rt/lib/ubsan/.. -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -fdiagnostics-color -Wall -std=c++14 -Wno-unused-parameter -g  -m32 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -nostdinc++ -fno-rtti -DUBSAN_CAN_USE_CXXABI -std=c++14 -MD -MT projects/compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.sparc.dir/ubsan_diag.cpp.o -MF projects/compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.sparc.dir/ubsan_diag.cpp.o.d -o projects/compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.sparc.dir/ubsan_diag.cpp.o -c /home/glaubitz/llvm-project/compiler-rt/lib/ubsan/ubsan_diag.cpp
  In file included from /home/glaubitz/llvm-project/compiler-rt/lib/ubsan/ubsan_diag.cpp:25:
  In file included from /usr/include/stdio.h:870:
  /usr/include/bits/stdio-ldbl.h:26:20: error: cannot apply asm label to function after its first use
  __LDBL_REDIR_DECL (vfprintf)
  ~~~~~~~~~~~~~~~~~~~^~~~~~~~~
  /usr/include/sys/cdefs.h:467:26: note: expanded from macro '__LDBL_REDIR_DECL'
    extern __typeof (name) name __asm (__ASMNAME ("__nldbl_" #name));
                           ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1 error generated.
  [412/5552] Building CXX object lib/MC/MCParser/CMakeFiles/LLVMMCParser.dir/MasmParser.cpp.o
  ninja: build stopped: subcommand failed.

See: http://lab.llvm.org:8014/#/builders/134


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88712/new/

https://reviews.llvm.org/D88712