[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

[Moritz Sichert via Phabricator via cfe-commits]

MoritzS created this revision.
MoritzS added a reviewer: dergachev.a.
Herald added subscribers: cfe-commits, Charusso.
Herald added a project: clang.
MoritzS requested review of this revision.

This type is used as an aggregate, i.e. it has no member functions.
Starting with C++20 types with deleted default constructors are not
aggregate types anymore which means that aggregate initialization will
not work for this class anymore. This leads to a compile error in
clang::AnalyzerOptions::getDiagOpts() for example.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92221

Files:
  clang/include/clang/Analysis/PathDiagnostic.h


Index: clang/include/clang/Analysis/PathDiagnostic.h
===================================================================
--- clang/include/clang/Analysis/PathDiagnostic.h
+++ clang/include/clang/Analysis/PathDiagnostic.h
@@ -95,8 +95,6 @@
   /// Whether the consumer should present the name of the entity that emitted
   /// the diagnostic (eg., a checker) so that the user knew how to disable it.
   bool ShouldDisplayDiagnosticName;
-
-  PathDiagnosticConsumerOptions() = delete;
 };
 
 class PathDiagnosticConsumer {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92221.308010.patch
Type: text/x-patch
Size: 520 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201127/0b8949cc/attachment.bin>