[PATCH] D92202: [clangd] Add symbol origin for remote index

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:164
   Result.References = Message.references();
-  Result.Origin = static_cast<clangd::SymbolOrigin>(Message.origin());
+  Result.Origin = static_cast<clangd::SymbolOrigin>(Message.origin()) |
+                  clangd::SymbolOrigin::Remote;
----------------
I think we should just overwrite rather than OR.
In practice the remote side is always going to be `Static`, but we don't really want to conflate this with the client-side static index.

Actually, do you think we should set this on the *outgoing* side (i.e. have the proto say remote)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92202/new/

https://reviews.llvm.org/D92202