[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

Anastasiia Lukianenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 27 02:33:56 PST 2020


anastasiia_lukianenko added a comment.

Nothing will happen with your examples, because the line length is less than column limit. But if I make parameters longer results will be:

  BreakBeforeInlineASMColon = false;
  
  asm volatile("rbffffit %[aVal], %[aVal]" : [aVal] "+r"(val)
               : "[aVaffffl]"(val));
  __asm__ __volatile__("str fffffx0, %0"
                       : "=fffffffffffffffffffffm"(regs->regs[0]));
  asm volatile("get\t%0,rffffffffsl" stringify(id)
               : "=dfffffffffffffffffffffff"(val))
  
  BreakBeforeInlineASMColon = true;
  
  asm volatile("rbffffit %[aVal], %[aVal]"
               : [aVal] "+r"(val)
               : "[aVaffffl]"(val));
  __asm__ __volatile__("str fffffx0, %0"
                       : "=fffffffffffffffffffffm"(regs->regs[0]));
  asm volatile("get\t%0,rffffffffsl" stringify(id)
               : "=dfffffffffffffffffffffff"(val))

And asking the question who will use this configuration:
We are trying to use the clang-format approach as a base for Xen [1] style formatting. During the state of testing clang-format with different configurations, we found that some points regarding the Xen coding style are not
configurable. Therefore, we decided to add them (this and other my patches [2], [3]) to be able to make a choice in different cases.

[1] - https://xenproject.org/
[2] - https://reviews.llvm.org/D92168
[3] - https://reviews.llvm.org/D91949


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91950/new/

https://reviews.llvm.org/D91950



More information about the cfe-commits mailing list