[PATCH] D92198: [clangd] Implement remote index handshake

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 26 18:06:49 PST 2020


kbobyrev updated this revision to Diff 307942.
kbobyrev added a comment.

This is working now. However, the handshake is actually deferred for
ProjectAwareIndex until the first request. I tried to invoke it via something
like `Opts.StaticIdx->estimateMemoryUsage()` in `ClangdMain.cpp` but the
problem is `getIndex()` will return `nullptr` until the `Config::current` is
ready. I'm not entirely sure when this happens so I can't promote handshake to
some sensible time point yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92198/new/

https://reviews.llvm.org/D92198

Files:
  clang-tools-extra/clangd/index/remote/Client.cpp
  clang-tools-extra/clangd/index/remote/Client.h
  clang-tools-extra/clangd/index/remote/Index.proto
  clang-tools-extra/clangd/index/remote/Service.proto
  clang-tools-extra/clangd/index/remote/server/Server.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92198.307942.patch
Type: text/x-patch
Size: 6436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201127/1f7440de/attachment.bin>


More information about the cfe-commits mailing list