[PATCH] D92167: [OpenMP][NFC] Encapsulate some CGOpenMPRuntime static methods in a utility class
Jon Chesterfield via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 26 08:25:04 PST 2020
JonChesterfield requested changes to this revision.
JonChesterfield added a comment.
This revision now requires changes to proceed.
This moves some private free functions into a CodeGenUtil class in the header so that the amdgpu plugin can call them in order to construct the kern_desc object. Said kern_desc object has the review comment "This kern_desc object should be deleted, not upstreamed." in the patch from which you extracted this change.
Instead of this, the kern_desc part of D86097 <https://reviews.llvm.org/D86097> should have been removed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92167/new/
https://reviews.llvm.org/D92167
More information about the cfe-commits
mailing list