[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

Sylvain Audi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 26 06:29:34 PST 2020


saudi updated this revision to Diff 307854.
saudi added a comment.

Update patch : clang-format fixes.

There remains some clang-tidy warnings in `Path.cpp` and `Path.h` from `llvm/Support`.
I would like extra opinions on this, because fixing them would break the homogeneity with the rest of the file, which exposes snake_case - like function names.
More code from `llvm/Support` have that clang-tidy mismatch, but adding Support to the clang-tidy exclusion seems a bit extreme...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92136/new/

https://reviews.llvm.org/D92136

Files:
  clang/lib/Frontend/VerifyDiagnosticConsumer.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/test/PCH/reloc-windows.c
  clang/test/PCH/reloc.c
  llvm/include/llvm/Support/Path.h
  llvm/lib/Support/Path.cpp
  llvm/unittests/Support/Path.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92136.307854.patch
Type: text/x-patch
Size: 10885 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201126/80615df8/attachment-0001.bin>


More information about the cfe-commits mailing list