[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 26 03:24:28 PST 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clangd/Selection.cpp:40
 
+std::string getLanguage(const clang::LangOptions &Lang) {
+  if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x)
----------------
Nit: any reason to use std::string here instead StringRef. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92157/new/

https://reviews.llvm.org/D92157



More information about the cfe-commits mailing list