[PATCH] D92155: Load plugins when creating a CompilerInvocation.

Yafei Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 26 00:40:52 PST 2020


psionic12 added a comment.

In D92155#2417758 <https://reviews.llvm.org/D92155#2417758>, @njames93 wrote:

> Is it possible to write tests for this, obviously they will only work with plugin support on the current platform.
> Also now that this is loaded from the command line, how will this play nicely with other tools that haven't been built with plugin support?



1. I'll try to write a test case for this.
2. If a tool is built with CLANG_PLUGIN_SUPPORT=OFF, then the executable will not expose the symbols, then if a user does send a plugin to the command line as a parameter, the diagnostic will warning "undefined symbol". This will case the plugin unloaded, but not involve the main clang procedure. Do you suggested that this is not an elegant way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92155/new/

https://reviews.llvm.org/D92155



More information about the cfe-commits mailing list