[PATCH] D90188: Add support for attribute 'using_if_exists'

[Erik Pilkington via Phabricator via cfe-commits]

erik.pilkington added inline comments.


================
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1704-1707
+void ASTDeclReader::VisitUnresolvedUsingIfExistsDecl(
+    UnresolvedUsingIfExistsDecl *D) {
+  VisitNamedDecl(D);
+}
----------------
aaron.ballman wrote:
> I'm not super familiar with this code, but is this change actually necessary? I would have expected this to be handled via `VisitNamedDecl` by virtue of `UnresolvedUsingIfExistsDecl` inheriting from `NamedDecl`.
I think its necessary -- `DeclVisitor` doesn't automatically visit the base classes. Every other `Visit*` function here manually visits the base classes too FWIW.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90188/new/

https://reviews.llvm.org/D90188