[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

[Stanislav Mekhanoshin via Phabricator via cfe-commits]

rampitec added a comment.

You need to add a new test for this new error.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:134
+  if (isAmdHsaOS() && getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS) {
+    report_fatal_error("GFX6 (SI) ASICs does not support AMD HSA OS type \n",
+                       false);
----------------
"do not support". I would also drop "(SI)" from the message. Maybe even better just "GFX6 does not support AMD HSA".


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:201
+      TargetTriple(TT), Gen(initializeGen(TT, GPU)),
+      InstrItins(getInstrItineraryForCPU(GPU)), LDSBankCount(0),
+      MaxPrivateElementSize(0),
----------------
Please keep original formatting.


================
Comment at: llvm/test/CodeGen/AMDGPU/directive-amdgcn-target.ll:1
-; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx600 < %s | FileCheck --check-prefixes=GFX600 %s
-; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=tahiti < %s | FileCheck --check-prefixes=GFX600 %s
----------------
You probably just need to change triple for these targets, not just drop them from the test.


================
Comment at: llvm/test/CodeGen/AMDGPU/lower-kernargs-si-mesa.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; FIXME: Manually added checks for metadata nodes at bottom
+; RUN: opt -mtriple=amdgcn-- -S -o - -amdgpu-lower-kernel-arguments %s | FileCheck -check-prefix=MESA %s
----------------
There are no such checks?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92115/new/

https://reviews.llvm.org/D92115