[PATCH] D91651: [clang] Add a warning (à la gcc) for too small enum bitfields

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 25 08:12:36 PST 2020


thakis added a comment.

Do you have any numbers on false positives / true positives uncovered by this tweak? In general, warning at use time instead of at declaration time tends to be much better for this rate, and we do this differently than gcc in several instances, because the gcc way has so many false positives that it makes warnings unusable, while warning on use makes the warning useful. So I'd like to see a better justification than "gcc does it" :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91651/new/

https://reviews.llvm.org/D91651



More information about the cfe-commits mailing list