[PATCH] D92051: [clangd] PopulateSwitch: disable on dependent enums.
Adam Czachorowski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 25 05:20:22 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf6970503d291: [clangd] PopulateSwitch: disable on dependent enums. (authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92051/new/
https://reviews.llvm.org/D92051
Files:
clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
clang-tools-extra/clangd/unittests/TweakTests.cpp
Index: clang-tools-extra/clangd/unittests/TweakTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/TweakTests.cpp
+++ clang-tools-extra/clangd/unittests/TweakTests.cpp
@@ -3084,6 +3084,12 @@
R""(enum Enum {A,B,b=B}; ^switch (A) {case A:case B:break;})"",
"unavailable",
},
+ {
+ // Enum is dependent type
+ File,
+ R""(template<typename T> void f() {enum Enum {A}; ^switch (A) {}})"",
+ "unavailable",
+ },
};
for (const auto &Case : Cases) {
Index: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
===================================================================
--- clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
+++ clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
@@ -126,7 +126,7 @@
return false;
EnumD = EnumT->getDecl();
- if (!EnumD)
+ if (!EnumD || EnumD->isDependentType())
return false;
// We trigger if there are any values in the enum that aren't covered by the
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92051.307591.patch
Type: text/x-patch
Size: 1083 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201125/4952cc7a/attachment.bin>
More information about the cfe-commits
mailing list