[PATCH] D92000: [clangd] Collect main file refs by default

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 25 03:59:40 PST 2020


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM.



================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:492
     desc("Store references to main-file-only symbols in the index"),
-    init(false),
+    init(true),
 };
----------------
can we just change the default in `ClangdServer::Options` and also use that one in here (i.e. `ClangdServer::Options().CollectMainFileRefs`)? without plumbing the change to symbolcollector and fileindex ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92000/new/

https://reviews.llvm.org/D92000



More information about the cfe-commits mailing list