[PATCH] D74704: Support -fuse-ld=lld for riscv

serge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 25 01:50:32 PST 2020


serge-sans-paille added inline comments.


================
Comment at: clang/test/lit.site.cfg.py.in:50
+if not "@CLANG_DEFAULT_LINKER@":
+    config.available_features('platform-linker')
+
----------------
thakis wrote:
> Why do you need this feature? clang invocations that want to use the platform linker can just pass `-fuse-ld=` or `-fuse-ld=ld`, no?
I think the RISCV tests are partly responsible from that dubious test: in `riscv64-toolchain.c:27` the test explicitly checks for a custom linker path, just like the one passed through `-DCLANG_DEFAULT_LINKER`. We should probably make this more narrow.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74704/new/

https://reviews.llvm.org/D74704



More information about the cfe-commits mailing list