[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 25 01:39:56 PST 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/support/FileCacheTests.cpp:15
+#include <atomic>
+#include <chrono>
+
----------------
kbobyrev wrote:
> Please sort the includes here (clangd should have a Code Action here).
The includes are sorted, this is a bug in the include order check that was fixed in D91602, but the pre merge bot isnt using the updated version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88172/new/

https://reviews.llvm.org/D88172



More information about the cfe-commits mailing list