[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Tue Nov 24 18:53:13 PST 2020

tentzen added a comment.

In D80344#2410417 <https://reviews.llvm.org/D80344#2410417>, @pengfei wrote:

> In D80344#2407305 <https://reviews.llvm.org/D80344#2407305>, @tentzen wrote:
>
>> In D80344#2407250 <https://reviews.llvm.org/D80344#2407250>, @pengfei wrote:
>>
>>> Do we need to consider FP exceptions in _try block?
>>
>> Yes, FP exception is handled as long as FP exceptions are not disabled (Ex via _controlfp() runtime) and FP exception code is filtered & handled via ___except() statement (Ex, ___except(GetExceptionCode()==EXCEPTION_FLT_INEXACT_RESULT)).
>
> I see. If this is the case, you may need to assign FPE_Strict to _try block to preserve FP instructions' order.

Is FPE_Strict in Clang/LLVM  equivalent to /fp:strict in VC++/Windows.  -EHa does not automatically imply /fp:strict semantic in Windows. So for FP sensitive cases, users can explicitly specify -EHa and -FPE_Strict together.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344