[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions
Anton Zabaznov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 24 12:37:26 PST 2020
azabaznov updated this revision to Diff 307436.
azabaznov marked 24 inline comments as done.
azabaznov added a comment.
Addressed almost all technical and cosmetic concerns concerns. Except putting reference of `OpenCLOptions` in `Sema` due to const of `TargetInfo`. I think I'll think about that later. Also:
1. Added new target hook to define extensions/features macros in one step (target settings + option)
2. Define generic address space macro if pipes or device enqueue is supported.
3. Did some minor refactoring of `OpenCLOptions.h` and `OpenCLExtensions.def`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89869/new/
https://reviews.llvm.org/D89869
Files:
clang/include/clang/Basic/OpenCLExtensions.def
clang/include/clang/Basic/OpenCLOptions.h
clang/include/clang/Basic/TargetInfo.h
clang/lib/Basic/TargetInfo.cpp
clang/lib/Basic/Targets.cpp
clang/lib/Frontend/InitPreprocessor.cpp
clang/lib/Headers/opencl-c-base.h
clang/lib/Parse/ParsePragma.cpp
clang/lib/Sema/Sema.cpp
clang/lib/Serialization/ASTReader.cpp
clang/lib/Serialization/ASTWriter.cpp
clang/test/SemaOpenCL/opencl-feature-extension-simult.cl
clang/test/SemaOpenCL/opencl-feature-generic-as-req.cl
clang/test/SemaOpenCL/opencl-features.cl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89869.307436.patch
Type: text/x-patch
Size: 30461 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201124/41ba6909/attachment-0001.bin>
More information about the cfe-commits
mailing list