[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 24 09:58:24 PST 2020


njames93 added a comment.

In D88172#2414249 <https://reviews.llvm.org/D88172#2414249>, @sammccall wrote:

> @kbobyrev ping... I think we do actually want to land this, for use with `.clang-tidy` files after D91029 <https://reviews.llvm.org/D91029>

Yes, I was looking at copying the config cache for use with `.clang-tidy`



================
Comment at: clang-tools-extra/clangd/support/FileCache.h:43
+  // Path must be absolute.
+  FileCache(llvm::StringRef Path);
+
----------------
nit: Is it more descriptive to have this spelled as `PathRef`, same for `path()` below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88172/new/

https://reviews.llvm.org/D88172



More information about the cfe-commits mailing list