[PATCH] D92037: clang: Pass -platform-version to new MachO LLD
Hans Wennborg via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 24 08:09:23 PST 2020
hans accepted this revision.
hans added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/include/clang/Driver/ToolChain.h:334
/// LLD's supported flags, error output, etc.
- std::string GetLinkerPath(bool *LinkerIsLLD = nullptr) const;
+ /// If LinkerIsLLDDarwinNew is non-nullptr, it's set if it's the in-progress
+ /// new version in lld/MachO.
----------------
ultra nit: the "in-progress" part doesn't really add much to the comment and might be obsolete soon, so i would probably have left that out. Also, strictly speaking, it's not immediately clear what the second "it" refers to here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92037/new/
https://reviews.llvm.org/D92037
More information about the cfe-commits
mailing list