[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 24 07:23:49 PST 2020


svenvh added a comment.

In D92004#2413603 <https://reviews.llvm.org/D92004#2413603>, @Anastasia wrote:

> @svenvh I imagine the testing functionality between the two headers will be identical?

Mostly, assuming you intend to test in the conventional way of feeding a .cl file to Clang.  Although currently `-fdeclare-opencl-builtins` only provides a subset of the builtins in `opencl-c.h`.

In the past I did have a look at the possibility of automated equivalence checking of declarations provided by both `-fdeclare-opencl-builtins` and `opencl-c.h`.  It shouldn't be impossible, but it's not trivial (one reason being that gentype-expansion is currently done in Sema).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92004/new/

https://reviews.llvm.org/D92004



More information about the cfe-commits mailing list