[PATCH] D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC]

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 24 06:57:07 PST 2020


ABataev added inline comments.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:411
 private:
-  SmallVector<SmallString<128u>, 4u> Files;
+  std::forward_list<SmallString<128u>> Files;
 };
----------------
sdmitriev wrote:
> ABataev wrote:
> > What about `llvm::iplist`?
> It can be changed to iplist as well, but why do you think it is a better option here?
Just better to use LLVM API if possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92010/new/

https://reviews.llvm.org/D92010



More information about the cfe-commits mailing list