[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 24 05:33:10 PST 2020


Anastasia added a comment.

In D92004#2412953 <https://reviews.llvm.org/D92004#2412953>, @airlied wrote:

> this file has never been clang-format clean, happy to make changes if reviewer decides they are needed.

This has not been considered a conventional clang source so to say, so the coding style has not been followed. But it is quite annoying now with formatting hooks being installed. Ideally, it would be good to format this properly but this makes retrieving the history harder and it is extremely valuable. So I suggest not to reformat the old code but for the new code I leave it up to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92004/new/

https://reviews.llvm.org/D92004



More information about the cfe-commits mailing list