[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

Tue Nov 24 00:22:04 PST 2020

nridge marked an inline comment as done.
nridge added inline comments.

================
Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86
+
+  auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get());
+  EXPECT_THAT(IncomingLevel3,
----------------
nridge wrote:
> kadircet wrote:
> > the order of elements in `IncomingLevel2` is not sorted, so on some buildbots you are receiving "caller3" as the first element of the result, and "caller2" in others.
> > 
> > sorry for missing it the first time, it might make sense to sort containers by name before returning from `incomingCalls`
> Thanks for catching that! Patch at https://reviews.llvm.org/D92000
Sorry, wrong link, correct link is: https://reviews.llvm.org/D92009

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91122/new/

https://reviews.llvm.org/D91122