[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Nov 24 00:11:43 PST 2020
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86
+
+ auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get());
+ EXPECT_THAT(IncomingLevel3,
----------------
the order of elements in `IncomingLevel2` is not sorted, so on some buildbots you are receiving "caller3" as the first element of the result, and "caller2" in others.
sorry for missing it the first time, it might make sense to sort containers by name before returning from `incomingCalls`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91122/new/
https://reviews.llvm.org/D91122
More information about the cfe-commits
mailing list