[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 23 12:35:56 PST 2020
njames93 added a comment.
Just one last small nit.
// You can ignore this, nothing to do with this patch.
All these changes in the documentation tell me we should probably restructure the documentation for this check.
Right now we have NxM lines of documentation for each combination of style kind(N) and style option(M).
This could probably be changed so we could describe each style option at the top of the documentation (`<StyleKind>Case`, `<StyleKind> Prefix`, ...)
Then we could describe each StyleKind afterwards.
.. option:: ClassCase, option::ClassPrefix...
Transforms class names
.. code-block:: c++
class <Ident> {
};
.. option:: FunctionCase, option::FunctionPrefix...
Transforms class names
.. code-block:: c++
void <Ident>(int Param0);
================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:149
+ StyleString.append("IgnoredRegexp");
+ std::string IgnoredRegexpStr = Options.get((StyleString).str(), "");
+ StyleString.resize(StyleSize);
----------------
Dont need to use `str()` here
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90282/new/
https://reviews.llvm.org/D90282
More information about the cfe-commits
mailing list