[PATCH] D91428: Add support for multiple program address spaces

Alexander Richardson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 23 12:08:45 PST 2020


arichardson requested changes to this revision.
arichardson added a comment.

I don't see why you would need multiple program address spaces to support calls to other address spaces. You can already do the following:

  define i32 @foo(i32) addrspace(1) {
      %ret = add i32 %0, 1
      ret i32 %ret
  }
  
  define i32 @bar() addrspace(0) {
      %call = call addrspace(1) i32 @foo(i32 1)
      ret i32 %call
  }

Isn't that sufficient for your WebAssembly changes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91428/new/

https://reviews.llvm.org/D91428



More information about the cfe-commits mailing list