[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

Yevgeny Rouban via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 22 21:34:47 PST 2020


yrouban added a comment.

In D91327#2408521 <https://reviews.llvm.org/D91327#2408521>, @kuhar wrote:

> Looks fine to me, but I'm not confident enough to give an approval.

Thanks. I'm working closely with @skatkov and believe he have enough expertise to review fully.
The biggest issue with the current design is that we have to send FAM to the initialization of StandardInstrumentations/PreservedCFGCheckerInstrumentation. This looks asymmetric to the other analysis managers and it would be more reasonable to send FAM or all AMs to the instrumentation callbacks as parameters.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91327/new/

https://reviews.llvm.org/D91327



More information about the cfe-commits mailing list