[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

[Nathan James via Phabricator via cfe-commits]

njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:134-137
+    if (!IgnoredRegexp.isValid()) {
+      llvm::errs() << "Invalid IgnoredRegexp regular expression: "
+                   << IgnoredRegexpStr;
+    }
----------------
Elide braces on single statement if.


================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:138-141
+  } else {
+    // Store an 'invalid' Regexp if empty string
+    IgnoredRegexp = llvm::Regex();
+  }
----------------
`IgnoredRegexp` will be default constructed anyway, so this doesn't add anything.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90282/new/

https://reviews.llvm.org/D90282