[PATCH] D91859: [clangd] Fix shared-lib builds

Sun Nov 22 05:00:55 PST 2020

kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.

Ah, right. I think `clangd-remote-index` needs `protobuf` dependency. @nridge, I believe this should fix the problem you're seeing. I'm somewhat confused as to why I'm not seeing the same problem though but it makes total sense to me.

In D91859#2409419 <https://reviews.llvm.org/D91859#2409419>, @kbobyrev wrote:

> (also please add "Fixes https://github.com/clangd/clangd/issues/598" to the patch description to close the related issue on GH)

Otherwise LGTM + patch description :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91859/new/

https://reviews.llvm.org/D91859