[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

Brooks Moses via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 21 16:15:19 PST 2020


brooksmoses added a comment.

Aha, okay.  I hadn't realized that this optimization had a `-fno-delete-null-pointer-checks` option to disable it.  I agree that since that's available there's no call for a rollback.

(I'll also make sure upstream bugs are filed for the cases in OpenJDK and Verilator that I know about, though I imagine those are likely to take a little while to make it out into the ecosystem.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D17993/new/

https://reviews.llvm.org/D17993



More information about the cfe-commits mailing list