[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 21 08:19:34 PST 2020


njames93 added a comment.

While I'm a fan of this change, I think this is the wrong way to do it. Leave the check the same, but build the regex in the pp callback constructor. That should only get called once for the lifetime of the check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91908/new/

https://reviews.llvm.org/D91908



More information about the cfe-commits mailing list