[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

Shane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 20 07:21:53 PST 2020


smhc updated this revision to Diff 306686.
smhc added a comment.

Updated diff to use 'IgnoredRegexp'
I see that a regexp has been used elsewhere for some other checks (macro usage, AllowedRegexp).

(as a side note, I see that AllowedRegexp string is getting compiled on every match rather than pre-compiling, the lack of a copy constructor on llvm::Regex makes it trickier to work with)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90282/new/

https://reviews.llvm.org/D90282

Files:
  clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
  clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst
  clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-ignore-regexp.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90282.306686.patch
Type: text/x-patch
Size: 41211 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201120/f5416d93/attachment-0001.bin>


More information about the cfe-commits mailing list