[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 20 05:19:15 PST 2020


jansvoboda11 added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:473
+    MarshallingInfoFlag<"DependencyOutputOpts.OutputFormat", "DependencyOutputFormat::Make">,
+    Normalizer<"makeFlagToValueNormalizer(DependencyOutputFormat::NMake)">;
 def Mach : Flag<["-"], "Mach">, Group<Link_Group>;
----------------
The original patch used the following normalizer:
`(normalizeFlagToValue<DependencyOutputFormat, DependencyOutputFormat::NMake>)`.

I wanted to remove the parenthesis and redundant type argument, hence `makeFlagToValueNormalizer`. This could be useful later on when normalizing flags to non-literal types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83694/new/

https://reviews.llvm.org/D83694



More information about the cfe-commits mailing list