[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 20 03:02:11 PST 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/Config.h:95
+  static inline ExternalIndexSpec getEmptyKey() {
+    static ExternalIndexSpec E{ExternalIndexSpec::File, "", ""};
+    return E;
----------------
(nit: static isn't saving anything here I think: cost of constructing == cost of copying)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90750/new/

https://reviews.llvm.org/D90750



More information about the cfe-commits mailing list