[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 19 21:13:22 PST 2020
rnk added inline comments.
================
Comment at: clang/include/clang/Frontend/FrontendOptions.h:307
+ /// Wheather using -mthread-model single.
+ unsigned IsSingleThreadModel : 1;
+
----------------
This doesn't seem to fit with the other frontend options. This seems more like a language option. See the existing PosixThreads langopt.
If you add a langopt, you should be able to remove the option from CodeGenOptions, since codegen can check language options.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91747/new/
https://reviews.llvm.org/D91747
More information about the cfe-commits
mailing list