[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.
Chris Kennelly via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 19 20:22:45 PST 2020
ckennelly added inline comments.
================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-redundant-string-init.cpp:65
+void fview() {
+ std::string_view a = "";
----------------
aaron.ballman wrote:
> Can you also add tests for `wstring_view`?
>
> Also, perhaps one for `std::string_view foo{};` (to remove the spurious `{}`)
Done for `wstring_view`
re `std::string_view foo{}`, it looks like we don't even match `std::string{}`, https://godbolt.org/z/zaafrb
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91009/new/
https://reviews.llvm.org/D91009
More information about the cfe-commits
mailing list