[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 19 12:45:36 PST 2020


aaron.ballman added inline comments.


================
Comment at: clang/docs/LibASTMatchersReference.html:91-94
+This mode is hard to use correctly and
+requires more development iteration because it means
+that the user must write AST Matchers to explicitly traverse or ignore nodes
+which are not visible.</p>
----------------
I was trying to reword this to avoid making a judgmental statement that the default mode is hard to use correctly -- I'd strike this part of the paragraph. WDYT?


================
Comment at: clang/docs/LibASTMatchersReference.html:303
+<tr>
+  <td>Replacement of `begin()` with `cbegin()`:
+<pre>
----------------
steveire wrote:
> aaron.ballman wrote:
> > Backticks won't help here -- should probably use <pre> tags.
> `pre` is equivalent to three backticks. I added a `span` for use within paragraphs.
Thank you for translating my suggestion into the one I was trying to make. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91639/new/

https://reviews.llvm.org/D91639



More information about the cfe-commits mailing list