[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

[Ten Tzen via Phabricator via cfe-commits]

tentzen added inline comments.


================
Comment at: llvm/docs/LangRef.rst:11591
+and the EH cleanup is no longer required (e.g. because the destructor is being
+called).
+
----------------
JosephTremoulet wrote:
> Maybe add something here like
> 
> > Any set of operations can then be confined to the region by reading their leaf inputs via volatile loads and writing their root outputs via volatile stores.
> 
> IIUC, for something like `x = 1 / y`, the volatile load of y and volatile store of x being things you can't move past these intrinsic calls is how you make sure the potentially-faulting divide stays in the right scope.  IMO it's a bit confusing to talk about "arbitrary faulting instructions" being constrained without that extra bit. 
Very good point!  will clarify as you suggested..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344