[PATCH] D83691: Port Comment option flags to new parsing system
Jan Svoboda via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 19 06:23:51 PST 2020
jansvoboda11 added a comment.
Thanks. Committing this without the NFC change.
================
Comment at: clang/include/clang/Driver/Options.td:407
+
+def fparse_all_comments : Flag<["-"], "fparse-all-comments">, Group<f_clang_Group>, Flags<[CC1Option]>,
+ MarshallingInfoFlag<"LangOpts->CommentOpts.ParseAllComments">;
----------------
dexonsmith wrote:
> Nit: is moving this option and adding a comment a necessary part of the patch, or is it just a cleanup that could be done before in an NFC commit? If it's possible, I would suggest moving it in a separate commit.
That's a fair point, moving the option is not necessary. I will revert the move in this patch and consider creating the `// Comment options.` section once all comment options get ported to the marshaling system.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83691/new/
https://reviews.llvm.org/D83691
More information about the cfe-commits
mailing list