[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 19 00:22:49 PST 2020
kadircet added inline comments.
================
Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108
bool CanReuse(const CompilerInvocation &Invocation,
- const llvm::MemoryBuffer *MainFileBuffer, PreambleBounds Bounds,
- llvm::vfs::FileSystem *VFS) const;
+ const llvm::MemoryBufferRef &MainFileBuffer,
+ PreambleBounds Bounds, llvm::vfs::FileSystem &VFS) const;
----------------
why not accept a value directly here? (i.e. drop const and ref)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91297/new/
https://reviews.llvm.org/D91297
More information about the cfe-commits
mailing list